Development - #188
Open
aniket-shikhare-cstk wants to merge 6 commits into
Open
Conversation
chore: back-merge main into development
chore: back-merge main into development
back merge
chore: back-merge main into development
… pattern
variants(x) treats its single positional arg as a branch UID, not a
variant UID, so variants("no_such_variant").fetch() left variant_uid=None
and hit the client-side ArgumentException guard before the HTTP call.
Fix: pass the UID to fetch() directly, which is the correct SDK pattern.
Generated by Claude Code
…nexistent fix(test): correct entry variants fetch_nonexistent to use fetch(uid) pattern
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the single failing test (test_fetch_nonexistent) in test_17_entry_variants.py that caused 269/270 on the last GoCD run
entry.variants(x) treats its single positional arg as a branch UID, not a variant UID — so .variants("no_such_variant").fetch() left variant_uid=None and hit the SDK's ArgumentException client-side guard before any HTTP call was made
Fix: .variants().fetch("no_such_variant") passes the UID to fetch() directly, which is the correct SDK pattern and reaches the server to get a 404/412/422 response